Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jim/FEQ-322/cannot-convert-undefined-or-null-to-object #9048

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Jim/FEQ-322/cannot-convert-undefined-or-null-to-object #9048

merged 7 commits into from
Jul 10, 2023
+4 −3

Conversation

jim-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the Trader label Jun 19, 2023
@vercel
Copy link

vercel bot commented Jun 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 7:04am

@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited
Loading

Codecov Report

Merging #9048 (ecfd2aa) into master (d5c38a0) will not change coverage.
The diff coverage is n/a.

❗ Current head ecfd2aa differs from pull request most recent head 8572114. Consider uploading reports for the commit 8572114 to get more accurate results

@@          Coverage Diff           @@
##           master   #9048   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files         117     117           
  Lines        3425    3425           
  Branches      893     893           
======================================
  Hits            2       2           
  Misses       3423    3423

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/9048](https://github.com/binary-com/deriv-app/pull/9048)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-feq-322cannot-convert-u-14ca79.binary.sx?qa_server=red.binaryws.com&app_id=23820
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-feq-322cannot-convert-u-14ca79.binary.sx
- **App ID**: `23820`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 18
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-feq-322cannot-convert-u-14ca79.binary.sx/

@coveralls
Copy link

coveralls commented Jul 3, 2023 •
edited
Loading

Coverage Status

coverage: 8.913%. remained the same when pulling b0766a0 on jim-deriv:Jim/FEQ-322/cannot-convert-undefined-or-null-to-object into ea9f6cb on binary-com:master.

@jim-deriv jim-deriv force-pushed the Jim/FEQ-322/cannot-convert-undefined-or-null-to-object branch from 4deb8b1 to a1c7c71 Compare July 5, 2023 07:00
adrienne-deriv
adrienne-deriv approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@ali-hosseini-deriv ali-hosseini-deriv merged commit 4ab4c5a into binary-com:master Jul 10, 2023
3 checks passed
@ali-hosseini-deriv
Copy link
Member

✨ PR has been merged by Paimon the Release Bot

@jim-deriv jim-deriv deleted the Jim/FEQ-322/cannot-convert-undefined-or-null-to-object branch November 23, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienne-deriv adrienne-deriv adrienne-deriv approved these changes

@maryia-deriv maryia-deriv maryia-deriv approved these changes

@yauheni-deriv yauheni-deriv yauheni-deriv approved these changes

@shontzu-deriv shontzu-deriv shontzu-deriv approved these changes

Assignees
No one assigned
Labels
Trader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jim-deriv @coveralls @ali-hosseini-deriv @adrienne-deriv @maryia-deriv @yauheni-deriv @shontzu-deriv